Fix config for uploads when data server is not exposed #936
Conversation
|
did you merge by mistake ? seems a review was missing not sure if related, but apparently the uploads do not work any more in ocis-reva after updating: owncloud/ocis-reva#362 |
|
@PVince81 We wanted to get started with OCM testing that day, so I merged it. This just changes the default prefix for the datagateway service to datagateway (it was data previously). Since by default, we start only one HTTP server, having the same prefix for datagateway and dataprovider doesn't work. Other than that, in case these are not provided in the config, we try to get the reva hostname and use that for these URLs before defaulting to localhost. So these are just changes in the default config. The error might be because of this if you use the defaults. |
|
yep, in ocis-reva we started them as separate services and were relying on the default settings. fixed with owncloud/ocis-reva#363 |
|
@butonic this was done to simplify the deployment for the partners. Sorry about that! |
For the standalone config,
expose_data_serveris set to false by default, while the datagateway wasn't previously started. This PR starts the datagateway HTTP service at a different prefix than the dataprovider service, and makes it work for both TUS and non-TUS uploads. Closes #844, closes #931